refactor: pass custom log to pubsub #3016
Closed
+33
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bailantaotao
changed the title
bailantaotao
force-pushed
the
edwin/pass-custom-log
branch
from
039a5dd to
58f023a
Compare
bailantaotao
force-pushed
the
edwin/pass-custom-log
branch
from
022f997 to
21a757d
Compare
|
@bailantaotao please sync with master |
|
@bailantaotao changing the loging interface here is a breaking change we cannot have at the moment. We will consider your suggestion for the next iteration for logging, but I will close this PR. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user subscribes to many channels, it becomes difficult to keep track of which channel's data has been missed.
#3015